Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat migrate login portail #3056

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Feat migrate login portail #3056

merged 5 commits into from
Nov 20, 2023

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review November 16, 2023 14:54
@pYassine pYassine force-pushed the feat-migrate-login-portail branch from c879587 to 82a3724 Compare November 20, 2023 15:20
@pYassine pYassine force-pushed the feat-migrate-login-portail branch from 82a3724 to bfa5dff Compare November 20, 2023 15:43
@pYassine pYassine force-pushed the feat-migrate-login-portail branch from 8c71caa to 3d4f9a2 Compare November 20, 2023 21:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023 •
edited
Loading

Codecov Report

Merging #3056 (0c1d6db) into master (1cf5459) will decrease coverage by 0.20%.
Report is 2 commits behind head on master.
The diff coverage is 59.18%.

❗ Current head 0c1d6db differs from pull request most recent head 1518e07. Consider uploading reports for the commit 1518e07 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3056      +/-   ##
==========================================
- Coverage   67.93%   67.73%   -0.20%     
==========================================
  Files         913      914       +1     
  Lines       14585    14679      +94     
  Branches     2096     2115      +19     
==========================================
+ Hits         9908     9943      +35     
- Misses       4406     4465      +59     
  Partials      271      271
Files Coverage Δ
..._common/model/interaction/INTERACTIONS_OK.const.ts 100.00% <ø> (ø)
...ges/backend/src/_common/model/message-sms/index.ts 100.00% <ø> (ø)
...s/_init-db/1603812391580-pr-env-create-database.ts 21.05% <ø> (ø)
...in-structures/services/admin-structures.service.ts 98.51% <ø> (-0.02%) ⬇️
...se/entities/message-sms/MessageSmsTable.typeorm.ts 100.00% <100.00%> (ø)
...tities/user-usager/UserUsagerLoginTable.typeorm.ts 100.00% <100.00%> (ø)
...backend/src/database/entities/user-usager/index.ts 100.00% <100.00%> (ø)
...backend/src/database/services/user-usager/index.ts 100.00% <100.00%> (ø)
...s/user-usager/userUsagerLoginRepository.service.ts 100.00% <100.00%> (ø)
...teractions/services/interactionsCreator.service.ts 88.67% <100.00%> (-0.80%) ⬇️
... and 20 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf5459...1518e07. Read the comment docs.

@pYassine pYassine force-pushed the feat-migrate-login-portail branch from 0c1d6db to 1518e07 Compare November 20, 2023 22:22
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link

🎉 Deployment for commit 1518e07 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-1518e07f7ad0541fe88351692ce482a281965608
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-1518e07f7ad0541fe88351692ce482a281965608
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-1518e07f7ad0541fe88351692ce482a281965608
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-1518e07f7ad0541fe88351692ce482a281965608
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@pYassine pYassine merged commit 2dcabad into master Nov 20, 2023
15 checks passed
@pYassine pYassine deleted the feat-migrate-login-portail branch November 20, 2023 22:31
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.144.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pYassine @codecov-commenter @SocialGroovyBot